cfpb / design-manual

⚠️ THIS REPO IS DEPRECATED ⚠️ A set of design principles and standards for the Consumer Financial Protection Bureau.
https://cfpb.github.io/design-manual/
Creative Commons Zero v1.0 Universal
98 stars 71 forks source link

Update text input border to grey 60 to match latest standards #503

Closed cfarm closed 7 years ago

cfarm commented 7 years ago

As discussed on hub, updates to the checkbox input borders are slated. These updates include making the border grey-60. This PR makes text inputs grey-60 to match.

Pending pull requests dependent on this change:

screen shot 2017-08-07 at 1 32 07 pm

*Note the above screenshot also depicts the change from https://github.com/cfpb/capital-framework/pull/553 which makes the input height 27px with the padding at 10px 3px. The existing implementation had the wrong padding (7px all around), making the height taller than 27px.

nataliafitzgerald commented 7 years ago

@cfarm - This looks perfect!

nataliafitzgerald commented 7 years ago

@cfarm Actually, now that I'm digging around I'm questioning the padding and height. I know the DM says "Padding: 10px 3px" but that DM page is so inconsistent and contradictory that I wouldn't want to make a change that we aren't certain about. The image you've shown above looks less tall than what we have now.

I took a look at the filter pattern and the height and padding look visually correct as they are:

screen shot 2017-08-07 at 4 42 33 pm
nataliafitzgerald commented 7 years ago

@cfarm Confirming that for the height and padding we will keep what we have now in terms of the code and update the specs to accurately reflect what's built.

Border: 1 px #919395 (Grey 60) Height: 35 px (includes border, padding, and text height) Padding: 7px

cfarm commented 7 years ago

@Scotchester @jimmynotjim can we get a merge?

cfarm commented 7 years ago

@Scotchester pushed those changes. Do I need to commit the compiled CSS before merging?

Scotchester commented 7 years ago

Do I need to commit the compiled CSS before merging?

Oh! Yes you do.

cfarm commented 7 years ago

Added compiled CSS!

Scotchester commented 7 years ago

:+1: