Closed cfarm closed 7 years ago
@cfarm - This looks perfect!
@cfarm Actually, now that I'm digging around I'm questioning the padding and height. I know the DM says "Padding: 10px 3px" but that DM page is so inconsistent and contradictory that I wouldn't want to make a change that we aren't certain about. The image you've shown above looks less tall than what we have now.
I took a look at the filter pattern and the height and padding look visually correct as they are:
@cfarm Confirming that for the height and padding we will keep what we have now in terms of the code and update the specs to accurately reflect what's built.
Border: 1 px #919395 (Grey 60) Height: 35 px (includes border, padding, and text height) Padding: 7px
@Scotchester @jimmynotjim can we get a merge?
@Scotchester pushed those changes. Do I need to commit the compiled CSS before merging?
Do I need to commit the compiled CSS before merging?
Oh! Yes you do.
Added compiled CSS!
:+1:
As discussed on hub, updates to the checkbox input borders are slated. These updates include making the border grey-60. This PR makes text inputs grey-60 to match.
Pending pull requests dependent on this change:
*Note the above screenshot also depicts the change from https://github.com/cfpb/capital-framework/pull/553 which makes the input height 27px with the padding at 10px 3px. The existing implementation had the wrong padding (7px all around), making the height taller than 27px.