search

cfpb / design-manual

⚠️ THIS REPO IS DEPRECATED ⚠️ A set of design principles and standards for the Consumer Financial Protection Bureau.
https://cfpb.github.io/design-manual/
Creative Commons Zero v1.0 Universal
98 stars 71 forks source link

Code snippets misaligned #506

Closed awolfe76 closed 7 years ago

awolfe76 commented 7 years ago

Example: https://cfpb.github.io/design-manual/best-practices/accessibility-best-practices.html

Screenshot

code

It looks like the bottom margin is set to 1.375em. Resetting it to 0 seems to be ok.

Screenshot 0

code-0

But a -.375em seems to be even better.

Screenshot -.375em

code-neg

FYI - there's also a class there, highlighter-rouge, which doesn't do anything. Maybe it used to handle this?

marteki commented 7 years ago

@awolfe76 Yep! I reported this same bug on the Capital Framework repo: https://github.com/cfpb/capital-framework/issues/555

Seems to be a conflict between the CSS files for the two systems that are supposed to work together.

awolfe76 commented 7 years ago

Thanks @marteki! Sorry about that. I'll close this one.