cfpb / design-manual

⚠️ THIS REPO IS DEPRECATED ⚠️ A set of design principles and standards for the Consumer Financial Protection Bureau.
https://cfpb.github.io/design-manual/
Creative Commons Zero v1.0 Universal
98 stars 71 forks source link

Complete the removal of Georgia #510

Closed nataliafitzgerald closed 6 years ago

nataliafitzgerald commented 6 years ago

This pull request is related to these issues:

Remove Georgia from Design Manual https://github.com/cfpb/design-manual/issues/499

Defining the use of Avenir Next vs. Georgia https://github.com/cfpb/design-manual/issues/347#issuecomment-274575048

In January of 2017 we decided that Avenir Next would be the default font site-wide. It appears that we may have started to move forward with this change but did not complete it. From what I can tell, we've stopped using Georgia for body copy on DM pages. But there are instances of images on the Typography page that still include Georgia. Georgia is also still included in the type hierarchy (although the supporting visual is in Avenir Next). This pull request aims to complete the removal of Georgia from the Design Manual (with the exception of some static images contained on the page that will need to be updated at a later date).

Additions

-

Removals

Changes

Testing

-

Review

Preview this PR without the whitespace changes

Screenshots

Notes

-

Todos

-

Checklist

nataliafitzgerald commented 6 years ago

@caheberer Good point. I actually don't know of any instances in our editorial guidelines where we specify that italics should be used. @kurzn - Can you consult?

kurzn commented 6 years ago

@nataliafitzgerald @caheberer yes that is an error in the guidelines re: publications. Working to have that fixed in the version that's circulating for approval.

nataliafitzgerald commented 6 years ago

Ok, sounds good. @caheberer - Can you take one more look at the latest commit and we can merge this?

Scotchester commented 6 years ago

Just to clarify: We're talking about our "publications", right? I would hope we'd still use italics to set off the titles of published works (books, movies, magazines, etc.), if we ever had a need to refer to them.

kurzn commented 6 years ago

@Scotchester Nope. AP doesn't use italics. Book titles are in quotation marks.

Scotchester commented 6 years ago

Ugh, AP. So good sometimes, so dumb other times.