cfpb / design-manual

⚠️ THIS REPO IS DEPRECATED ⚠️ A set of design principles and standards for the Consumer Financial Protection Bureau.
https://cfpb.github.io/design-manual/
Creative Commons Zero v1.0 Universal
98 stars 71 forks source link

Update forms page to align with Capital Framework and cfgov-refresh #512

Closed nataliafitzgerald closed 6 years ago

nataliafitzgerald commented 6 years ago

Goals:

Related issues:

https://[GHE]/CFGOV/platform/issues/1085 https://[GHE]/CFGOV/platform/issues/1086

Related docs:

My fork of the forms page: http://nataliafitzgerald.github.io/design-manual/page-components/form-fields.html

Content doc: https://docs.google.com/document/d/1ZVJ-tgHo8oweVw4N5eitxMKIRLo9_s8qMuAoqN9YSMg/edit?userstoinvite=lorelei.kelly@collab.cfpb.gov&ts=598c7fcd

Review

Preview this PR without the whitespace changes

Screenshots

Notes

-

Todos

-

Checklist

nataliafitzgerald commented 6 years ago

@cfarm @marteki If we decide to move forward with calling this "Forms" instead of "Form fields" I may need a hand with changing the left nav.

kurzn commented 6 years ago

Looks good. One suggestion - create a new H3 sibling to Checkboxes called "Nested checkboxes" and move the usability content from Checkboxes referring to that under the new section and add the indeterminate states to it as well.

nataliafitzgerald commented 6 years ago

@cfarm - Can we merge?