cfpb / design-manual

⚠️ THIS REPO IS DEPRECATED ⚠️ A set of design principles and standards for the Consumer Financial Protection Bureau.
https://cfpb.github.io/design-manual/
Creative Commons Zero v1.0 Universal
98 stars 71 forks source link

Update grays for repo-list element #513

Closed nataliafitzgerald closed 6 years ago

nataliafitzgerald commented 6 years ago

Grays for the repo-list element on DM pages are not updated to our latest color palette naming convention and do not have sufficient contrast. Additionally we pull in a type style that isn't in our type hierarchy for the "p" text under the heading. I went ahead and changed this to 1em.

Changes

Testing

Review

Screenshots

Before

screen shot 2017-08-23 at 6 07 53 pm

After

screen shot 2017-08-23 at 6 07 47 pm

Notes

-

Todos

-

Checklist

nataliafitzgerald commented 6 years ago

@cfarm - One remaining change I'd like to make is to vertically center the text and icon within the gray box. Currently the text and icon sit a bit too low in the box. I poked around at doing this but couldn't find an ideal way to fix it. Can you make any suggestions?

nataliafitzgerald commented 6 years ago

@cfarm - A lot of what you see here for form-fields updates were me trying to fix conflicts that came up when I tried to merge the updates to the repo-list styling. I'll probably need a refresher on how to do that efficiently. ;)

It would also probably be ideal for me to start working on specific branches when I work on different pages so that my PR's can be properly focused. I'll need a refresh on how to work that way.

cfarm commented 6 years ago

Works as advertised!