Closed nataliafitzgerald closed 6 years ago
@cfarm - One remaining change I'd like to make is to vertically center the text and icon within the gray box. Currently the text and icon sit a bit too low in the box. I poked around at doing this but couldn't find an ideal way to fix it. Can you make any suggestions?
@cfarm - A lot of what you see here for form-fields updates were me trying to fix conflicts that came up when I tried to merge the updates to the repo-list styling. I'll probably need a refresher on how to do that efficiently. ;)
It would also probably be ideal for me to start working on specific branches when I work on different pages so that my PR's can be properly focused. I'll need a refresh on how to work that way.
Works as advertised!
Grays for the repo-list element on DM pages are not updated to our latest color palette naming convention and do not have sufficient contrast. Additionally we pull in a type style that isn't in our type hierarchy for the "p" text under the heading. I went ahead and changed this to 1em.
Changes
Testing
Review
Screenshots
Before
After
Notes
-
Todos
-
Checklist