cfpb / design-manual

⚠️ THIS REPO IS DEPRECATED ⚠️ A set of design principles and standards for the Consumer Financial Protection Bureau.
https://cfpb.github.io/design-manual/
Creative Commons Zero v1.0 Universal
98 stars 71 forks source link

Separated out "Large target areas" into its own section within forms page #522

Closed nataliafitzgerald closed 7 years ago

nataliafitzgerald commented 7 years ago

Separated out "Large target areas" into its own section and added to jump links menu. This makes more sense for the page hierarchy. There is still a future need to break this page up into separate pages but this update makes the most sense in the short term.

Additions

Removals

-

Changes

-

Testing

-

Review

Preview this PR without the whitespace changes

Screenshots

screen shot 2017-09-13 at 6 50 16 pm screen shot 2017-09-13 at 6 50 24 pm

Notes

-

Todos

-

Checklist

ielerol commented 7 years ago

I think it should be possible to keep the longer name of the section lower on the page, and still use a short label in the jump links at the top. The link at the top would just look like [Large target areas](#checkboxes-and-radio-buttons-with-large-target-areas). The part after the hashtag has to match the actual words of the h2, but link text in brackets can be different. Not a big deal, but since the shortened title is a bit ambiguous I'd like to keep the longer title lower on the page.

nataliafitzgerald commented 7 years ago

@ielerol - Yep, that change makes sense. I went ahead and made the update and posted the commit. Can you take a look and merge if it looks good to go?