Closed ielerol closed 6 years ago
@ielerol This looks good.
For the section where we talk about the parts of the modal can we call out the parts more - maybe with headings? (Also, let's change "headline" to "heading" to be consistent with the rest of the DM.)
Heading Modal windows should have a clear heading at the top of the window. This heading should clearly state what is happening or what action a modal is prompting the user for. For instance, if a modal appears due to inactivity, the heading should clearly state the action that is about to take place due to that inactivity.
Supporting text Any copy underneath the heading should include clear instructions about what the user needs to do.
Form fields If form fields are included in a modal, they should follow standard form field design guidelines.
None of this is official styling just my preference and what I used on the forms page.
@nataliafitzgerald ok, I made those updates here: https://ielerol.github.io/design-manual/page-components/modals.html#content-guidelines
Let me know if you see anything else.
@ielerol It looks like we still need to add parenthesis in 2 spots:
We've changed how the colors data file works, so pulling from that file to this page doesn't work anymore. I've updated the colors to be hard-coded based on the current color palette file. I also did some cleanup of the markdown file that shouldn't affect how it looks.
Preview the page here. All the visible changes should be in the style section.