cfpb / design-manual

⚠️ THIS REPO IS DEPRECATED ⚠️ A set of design principles and standards for the Consumer Financial Protection Bureau.
https://cfpb.github.io/design-manual/
Creative Commons Zero v1.0 Universal
98 stars 71 forks source link

Update hypothesis for canvas size, icon size, and line weight changes. #562

Closed jimmynotjim closed 6 years ago

jimmynotjim commented 6 years ago

Based on feedback from testing the initial draft set, make adjustments for another round of in-place testing.

Dnpizarro commented 6 years ago

Updated Artboard

I updated the artboard template to reflect the 1200pt height. @jimmynotjim @designlanguage https://drive.google.com/drive/folders/1A8u5GzmxH357bbK9N8pAn9LCoaLB0HpF

screen shot 2018-01-12 at 2 56 51 pm
jimmynotjim commented 6 years ago

@Dnpizarro I think there was a miscommunication, the extra 200pts should just be empty white space above the ascender. The round icons were sized correctly but needed the extra whitespace for them to maintain their relationship with the rendered canvas of Avenir at 16px.

Dnpizarro commented 6 years ago

Here is the updated file with the correct measurements: https://drive.google.com/drive/folders/1A8u5GzmxH357bbK9N8pAn9LCoaLB0HpF

screen shot 2018-01-16 at 10 14 57 am
jimmynotjim commented 6 years ago

@Dnpizarro cool, that looks right to me. Thanks for the quick fix.

designlanguage commented 6 years ago

The gap at the top is more than 200 px (it's larger than the descender which 240 px). I made an update:

screen shot 2018-01-16 at 11 23 55 am

designlanguage commented 6 years ago

@Dnpizarro - For open icon sizing within the artboard, here's what I'm thinking:

screen shot 2018-01-16 at 12 15 14 pm

Circle icons fill the artboard, so we can treat the open icons similarly. I've kept these aligned with the baseline until they get taller than the ascender height, then they fall below the baseline.

Here's how that would play out with our current test set:

screen shot 2018-01-16 at 12 19 46 pm

@jimmynotjim - I'm wondering if for the web it makes sense to align these to the right edge of artboard. Would that make it easier to have a consistent amount of space between the icon and type? The downside is that the minicons would start at different places on the lefthand side.

Centered Flush-right
screen shot 2018-01-16 at 12 39 21 pm screen shot 2018-01-16 at 12 39 13 pm
jimmynotjim commented 6 years ago

@designlanguage I think these are working a lot better.

For the alignment, we currently remove the left and right whitespace as part of the cleanup process and the spacing between the icon and the text is controlled via CSS. While right aligning the icons would make it easier to stay consistent, it creates a new issue with icons that fall after the text, like links to documents or external websites. I think we should continue removing left and right whitespace and figure out a container solution with CSS and markup for instances where there's a list of icons and text.

designlanguage commented 6 years ago

Makes sense to me @jimmynotjim . I'll assemble our test set at this size/alignment. I'll try to have that for you by EOD.

jimmynotjim commented 6 years ago

Awesome. Let's move this one to done and use #563 for discussion around the icons

Dnpizarro commented 6 years ago

@designlanguage the only issue I foresee is the space between lines. The example below has a consistent 60px height between the lines. I went with 60px because the lines tend to blend together at small sizes. Let me know your thoughts.

screen shot 2018-01-18 at 12 46 18 pm
designlanguage commented 6 years ago

Thanks @Dnpizarro, that looks good!