cfpb / design-manual

⚠️ THIS REPO IS DEPRECATED ⚠️ A set of design principles and standards for the Consumer Financial Protection Bureau.
https://cfpb.github.io/design-manual/
Creative Commons Zero v1.0 Universal
98 stars 71 forks source link

Add list section to web hierarchy section #598

Closed nataliafitzgerald closed 6 years ago

nataliafitzgerald commented 6 years ago

Adds bulleted lists, numbered lists, nested lists, and link lists to the DM.

Additions

Removals

-

Changes

-

Testing

-

Review

Preview this PR without the whitespace changes

Screenshots

screencapture-0-0-0-0-4000-brand-guidelines-typography-html-1519423142199

Notes

-

Todos

-

Checklist

Scotchester commented 6 years ago

A few questions/comments:

  1. Similar to what I suggested to Jimmy in the Capital Framework docs, is it necessary to break out the nested styles into separate sections, or could we just include a nested list within each of the main list sections?
  2. Is it worth showing a nested numbered list? (I.e., an example where both parent and child lists are numbered.)
  3. The "16px / 8px" is somewhat confusing to me. Typically that kind of construction would represent type size / leading, but the 8px here is intended to represent the extra margin between list items, correct? I think it'd be good to be more explicit about that.
nataliafitzgerald commented 6 years ago

@Scotchester I've captured your recommendations and will submit a separate PR next week to address them. I think your points 1 and 3 make sense. In terms of including the nested numbered list, I can certainly include it but I haven't seen a use case for this in our content. Have you? I just want to make sure that the patterns we're including are something we'd want people to use.

Do you feel comfortable with merging what we have here as a first step?