cfpb / design-manual

⚠️ THIS REPO IS DEPRECATED ⚠️ A set of design principles and standards for the Consumer Financial Protection Bureau.
https://cfpb.github.io/design-manual/
Creative Commons Zero v1.0 Universal
98 stars 71 forks source link

Additional updates to list content #599

Closed nataliafitzgerald closed 6 years ago

nataliafitzgerald commented 6 years ago

Additional updates to list content as detailed here: https://github.com/cfpb/design-manual/issues/357#issuecomment-368171348

Additions

Removals

-

Changes

-

Testing

-

Review

Preview this PR without the whitespace changes

Screenshots

screencapture-0-0-0-0-4000-brand-guidelines-typography-html-1519843807219

Notes

-

Todos

-

Checklist

Scotchester commented 6 years ago

Sorry to nitpick, but I still think we need a description of how top-level lists (both bulleted and numbered) should be aligned horizontally. Here's a stab at the language:

Bulleted list (new bullet under its "Default" heading):

  • Bullets should align flush with the left margin of the column of text they're in.

Numbered list (modified final bullet under its "Default" heading):

  • Numbers are right aligned to their associated period, which sits just far enough off the left margin that all single-digit numbers will fit inside the left margin.
nataliafitzgerald commented 6 years ago

@Scotchester I tried out the text you proposed.

Bulleted list (default)

screen shot 2018-02-28 at 11 45 57 am

Numbered list (default)

The numbered list text is pretty dense (see below). I tried a shortened option (also below).

Full text

screen shot 2018-02-28 at 11 37 02 am

Shortened text

screen shot 2018-02-28 at 11 43 39 am
Scotchester commented 6 years ago

I think the shortened one works. This is super minor, but I would lastly suggest removing the parentheses and separating it from the previous statement with a semicolon.

I'm a little bit curious as to why the nested bullets seem to be aligned too far left in your screenshots. What browser are those from?

nataliafitzgerald commented 6 years ago

@Scotchester - Here's the latest tweak:

screen shot 2018-02-28 at 1 41 09 pm

I'm going to go ahead and push these changes to the branch and then I'll update the screenshot (above) of the full page. I have been working in Google Chrome. Where are you noticing an alignment issue?

nataliafitzgerald commented 6 years ago

@Scotchester I updated the screenshot at the top of this issue. The screenshot is from Google Chrome.

Scotchester commented 6 years ago

I don't know what changed, but in the original screenshot, the nested bullets looked like they were too far to the left. They seem fine now.

nataliafitzgerald commented 6 years ago

Thanks for your approval @Scotchester and @marteki. I will go ahead and merge.