cfpb / design-manual

⚠️ THIS REPO IS DEPRECATED ⚠️ A set of design principles and standards for the Consumer Financial Protection Bureau.
https://cfpb.github.io/design-manual/
Creative Commons Zero v1.0 Universal
98 stars 71 forks source link

Update to use family-linked webfonts and stop using mixins #601

Closed Scotchester closed 6 years ago

Scotchester commented 6 years ago

Switches from using our old u-webfont- mixins to simple CSS styling, in accordance with the current version of Capital Framework which defaults to family-linked webfonts.

Changes

Removals

Testing

  1. Pull branch
  2. grunt
  3. bundle exec jekyll serve watch
  4. Visit http://localhost:4000/ and browse around; see fonts looking as they should

Preview this PR without the whitespace changes

Checklist

jimmynotjim commented 6 years ago

Searched the repo and it looks like you found them all. At this point can we remove all references to the mixins from cf-core?

Scotchester commented 6 years ago

Searched the repo and it looks like you found them all. At this point can we remove all references to the mixins from cf-core?

Probably? I'm sure there are projects still using them, but as long as we do a major version update, that shouldn't be a big deal.

jimmynotjim commented 6 years ago

I'm sure there are projects still using them, but as long as we do a major version update, that shouldn't be a big deal.

Shoot, we should have included this in the v5 release. We'll have to make sure we don't forget when we remove the icon font in v6.