cfpb / design-manual

⚠️ THIS REPO IS DEPRECATED ⚠️ A set of design principles and standards for the Consumer Financial Protection Bureau.
https://cfpb.github.io/design-manual/
Creative Commons Zero v1.0 Universal
98 stars 71 forks source link

Adds states for secondary and destructive buttons #604

Closed nataliafitzgerald closed 6 years ago

nataliafitzgerald commented 6 years ago

Adds states for secondary and destructive buttons (as built in Capital Framework)

Additions

Removals

-

Changes

Testing

-

Review

Preview this PR without the whitespace changes

Screenshots

screen shot 2018-03-01 at 3 22 07 pm screen shot 2018-03-01 at 3 22 17 pm screen shot 2018-03-01 at 3 25 38 pm

Notes

-

Todos

-

Checklist

marteki commented 6 years ago

Out of scope for this PR, but noting while I'm paying attention: there's the whole thing about destructive actions paired with primary button, where we refer to a "destructive action button link."

screen shot 2018-03-01 at 4 03 31 pm

Button links aren't a thing that's mentioned anywhere else on the page, and it feels weird to just refer to it without more guidance about how to use them (and maybe more importantly, how not to use them).

nataliafitzgerald commented 6 years ago

@marteki I updated the page and placed the "States" section heading back in.

screen shot 2018-03-01 at 5 31 02 pm
jimmynotjim commented 6 years ago

Related note, we also use button links in expandables, but then they don't have the underline, just the text and icon.