Updates the project assets to use the latest release from Capital Framework.

cfpb / design-manual

⚠️ THIS REPO IS DEPRECATED ⚠️ A set of design principles and standards for the Consumer Financial Protection Bureau.

https://cfpb.github.io/design-manual/

Creative Commons Zero v1.0 Universal

98 stars 71 forks source link

Updates the project assets to use the latest release from Capital Framework. #615

Closed jimmynotjim closed 5 years ago

jimmynotjim commented 5 years ago

Updates the project to use the latest release from Capital Framework.

Changes

~~Updates cf-expandables v7.0.0~~
~~Updates cf-atomic-component to v2.0.0~~
~~Updates cf-tables to v5.0.0~~
Adds initialization code for cf-expandables and cf-tables.
Regenerates assets with grunt.

(Added by Ans)

Testing

Run npm start
Open http://localhost:4000/page-components/expandables.html and make sure the expandables continue to work
Open http://localhost:4000/page-components/tables.html and make sure the tables continue to work

Notes

We'll need decide what to do about accordions documentation. Turns out they are necessary for the OaH explanations, but I don't know how much we want to encourage their use outside of those pages. The simplest answer is to probably revert this change https://github.com/cfpb/design-manual/commit/bb035a7ca5245d8093bcda54b3269044e28fe331#diff-7c1ba7f64a56bc337d12c911525c729f but I'll leave that up to the design team.

Scotchester commented 5 years ago

The dependency versions in package.json don't match what you're saying in the PR.

jimmynotjim commented 5 years ago

@Scotchester thanks for catching that, not sure what I was doing, fixed it though.

jimmynotjim commented 5 years ago

@Scotchester blah, I completely forgot to ping you about this one before I left. You may want to run it locally and make sure I updated and rebuilt correctly the second time before merging. 🎩

Scotchester commented 5 years ago

@jimmynotjim No worries, I haven't forgotten it, just been busy :)

jimmynotjim commented 5 years ago

😢 Sooooo lonely....

Scotchester commented 5 years ago

Please hold. I want to release the couple patches that are merged and then update this PR.