Closed billhimmelsbach closed 9 months ago
Name | Link |
---|---|
Latest commit | 5cbe64d69e0a6629f391a8d12cf4a765e02de316 |
Latest deploy log | https://app.netlify.com/sites/cfpb-design-system-react/deploys/65b8e87f44b9c20008169bc2 |
Deploy Preview | https://deploy-preview-294--cfpb-design-system-react.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Thanks @meissadia! I appreciate the thinking about the naming.
Closes: https://github.com/cfpb/sbl-frontend/issues/117
Well this took some experimentation, but we got there. Allows
Link
to use aisRouterLink
prop to convert them toreact-router
links with minimal hassle.Changes
react-router-dom
as an external dependency in the vite config, sincereact-router
needs its links to share the same instance of the library to work. Works in concert with this change insbl-frontend
. What a pain this was. (Also, I added a maybe missingreact-dom
from theoptimizeDeps.exclude
array for good measure)isRouterLink
prop that switchesLink
to usingreact-router
LinksisRouterLink
prop called "Link using React Router Link"How to test this PR
isRouterLink
story "Link using React Router Link" render without errors?Screenshots
Notes
NavLink
option, but I don't think we have a use case for it since we have some similar logic built out already. I made a ticket for it, in case we want to add it in.