cfpb / design-system-react

A React/Storybook implementation of CFPB's Design System
https://cfpb.github.io/design-system-react/
MIT License
6 stars 4 forks source link

feat(Link): add react-router link integration #294

Closed billhimmelsbach closed 9 months ago

billhimmelsbach commented 9 months ago

Closes: https://github.com/cfpb/sbl-frontend/issues/117

Well this took some experimentation, but we got there. Allows Link to use a isRouterLink prop to convert them to react-router links with minimal hassle.

Changes

How to test this PR

  1. Does the isRouterLink story "Link using React Router Link" render without errors?

Screenshots

Screenshot 2024-01-29 at 11 15 16 PM

Notes

netlify[bot] commented 9 months ago

Deploy Preview for cfpb-design-system-react ready!

Name Link
Latest commit 5cbe64d69e0a6629f391a8d12cf4a765e02de316
Latest deploy log https://app.netlify.com/sites/cfpb-design-system-react/deploys/65b8e87f44b9c20008169bc2
Deploy Preview https://deploy-preview-294--cfpb-design-system-react.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

billhimmelsbach commented 9 months ago

Thanks @meissadia! I appreciate the thinking about the naming.