cfpb / design-system-react

A React/Storybook implementation of CFPB's Design System
https://cfpb.github.io/design-system-react/
MIT License
6 stars 4 forks source link

fix(Navbar): CFPB logo always takes you to consumerfinance.gov #296

Closed billhimmelsbach closed 9 months ago

billhimmelsbach commented 9 months ago

The CFPB logo should always navigate to consumerfinance.gov instead of a generic / to allow for applications with their own routing that are using the navbar, as per @natalia-fitzgerald's designs.

Changes

How to test this PR

  1. Does clicking the CFPB logo in the NavBar take you to the CFPB home page?

Notes

netlify[bot] commented 9 months ago

Deploy Preview for cfpb-design-system-react ready!

Name Link
Latest commit 66923769aff55292c681f795961ae9c6f5b60a8c
Latest deploy log https://app.netlify.com/sites/cfpb-design-system-react/deploys/65b9bcf8bce3cd000963b527
Deploy Preview https://deploy-preview-296--cfpb-design-system-react.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

shindigira commented 9 months ago

@billhimmelsbach Don't forget to close issue #295.