fix: [Icon] Restrict wrapper height to match icon height

cfpb / design-system-react

A React/Storybook implementation of CFPB's Design System

https://cfpb.github.io/design-system-react/

MIT License

6 stars 4 forks source link

fix: [Icon] Restrict wrapper height to match icon height #312

Open meissadia opened 8 months ago

meissadia commented 8 months ago

Closes #303

This PR eliminates the extra height we were seeing from the .cf-icon-svg-wrapper elements...but it still doesn't seem to correct the odd alignment issues.

Other things I've tried:

Changing the .cf-icon-svg's vertical-align property. The only value that seems like it may be an improvement is vertical-align: sub, which shifts icons down 1 or 2 pixels.

Changes

How to test this PR

Screenshots

Notes

netlify[bot] commented 8 months ago

Deploy Preview for cfpb-design-system-react ready!

Name	Link
Latest commit	620d6209aa30f7bb0f0e1f2f01f14c1f85503395
Latest deploy log	https://app.netlify.com/sites/cfpb-design-system-react/deploys/65d526d79b98250008e6973c
Deploy Preview	https://deploy-preview-312--cfpb-design-system-react.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.