search

cfpb / design-system-react

A React/Storybook implementation of CFPB's Design System
https://cfpb.github.io/design-system-react/
MIT License
6 stars 4 forks source link

Pin underlying design-system deps to latest #336

Open wpears opened 5 months ago

wpears commented 5 months ago

Currently, carat matching is used for the DS dep. Because of how the DS is using semver, this means it will always pull in the latest, when that might be breaking. Particularly, https://github.com/cfpb/design-system/pull/1919 will need to be incorporated here to not cause breakages once that gets merged.

Another solution is to use semver more correctly in the DS, ie, put anything breaking behind a major version update. But for now, this PR is nice defense against changes there.

netlify[bot] commented 5 months ago

Deploy Preview for cfpb-design-system-react failed.

Name Link
Latest commit 22c1f88d0916f3400e83005a088d6676ed703557
Latest deploy log https://app.netlify.com/sites/cfpb-design-system-react/deploys/661e85f99c7c790008a71638