search

cfpb / design-system-react

A React/Storybook implementation of CFPB's Design System
https://cfpb.github.io/design-system-react/
MIT License
6 stars 4 forks source link

feat: [TextIntroduction] Support ReactNode content in the `description` #339

Closed meissadia closed 4 months ago

meissadia commented 4 months ago

Close #338

On SBL we have some descriptions that include lists (Errors page: download and upload links). I'm seeing console errors about nesting uls within paragraphs.

This PR basically renders description within a <p> tag if it's a string, otherwise renders it unchanged allowing us to pass more customized content.

Screenshot 2024-05-02 at 10 29 42 AM
netlify[bot] commented 4 months ago

Deploy Preview for cfpb-design-system-react ready!

Name Link
Latest commit 385d921201755a34ec6fb70f249365b6326bcbba
Latest deploy log https://app.netlify.com/sites/cfpb-design-system-react/deploys/6634192a7947dd0008eed2f0
Deploy Preview https://deploy-preview-339--cfpb-design-system-react.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

meissadia commented 4 months ago

@shindigira Fixed.