style(Pagination): Button icons hidden & Button content centered

cfpb / design-system-react

A React/Storybook implementation of CFPB's Design System

https://cfpb.github.io/design-system-react/

MIT License

6 stars 4 forks source link

style(Pagination): Button icons hidden & Button content centered #343

Closed shindigira closed 4 months ago

shindigira commented 4 months ago

closes #342

Note

Includes fixes from https://github.com/cfpb/design-system-react/pull/337 to pass the Netlify build tests

Changes

accessibility(pagination): button icons enable isPresentational to be ignored
styling(pagination): button content is flex-centered.

Screenshot

netlify[bot] commented 4 months ago

Deploy Preview for cfpb-design-system-react ready!

Name	Link
Latest commit	03adbc360f5cc6ba90321d3f23e673b0f2ec2a3f
Latest deploy log	https://app.netlify.com/sites/cfpb-design-system-react/deploys/664285f388c0dd000800499d
Deploy Preview	https://deploy-preview-343--cfpb-design-system-react.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

shindigira commented 4 months ago

Sorry to backtrack, but this setting seems a bit questionable.

Looking at the Changeset in Chromatic, it seems that every story's screenshot is getting regenerated - whether or not there are actual changes to the UI.

Was there something that you saw previously in Chromatic that sparked you to add this flag?

The build tests weren't passing so I pulled in ans's update; it fixed it but then for some reason the chromatic snapshots are being compared.

I reverted the autoAcceptChanges setting since it doesn't prevent the screenshots from being generated; I don't know why every story's screenshot is getting generated.