Closed BrewCityBoy closed 5 months ago
Name | Link |
---|---|
Latest commit | 78dc187dc2e3d98a83e250c9a7b7140f57cd505f |
Latest deploy log | https://app.netlify.com/sites/cfpb-design-system-react/deploys/66462986cebdd800084fa22b |
Deploy Preview | https://deploy-preview-346--cfpb-design-system-react.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Description
Currently, the CFPB logo in the React DS has a hardcoded href pointing to cf.gov. Using the CFPB logo from the React DS, we've run into the issue of users being booted from the Metro2 tool when the logo is clicked. This will inevitably cause frustration and confusion, as users will expect to be routed back to the landing page for the Metro2 Evaluator Tool.
This PR seeks to implement a change which will turn the logo href into a prop that can be defined in every project that uses the React DS component. Additionally, the logo still defaults to cf.gov if no other href/url is specified.
Changes
How to test this PR
Pull branch and run
yarn start
. Navigate to Navbar and Page header pages and verify CFPB logo points to cf.govCreate a story for either Navbar or PageHeader:
export const CustomCFPBHref: Story = { args: { href: 'https://www.google.com' } };
Check added test with
yarn test
and verify tests passNotes