cfpb / design-system-react

A React/Storybook implementation of CFPB's Design System
https://cfpb.github.io/design-system-react/
MIT License
6 stars 4 forks source link

fix: [Table] Pagination input label's 'for' property needs to align with the input id #356

Closed meissadia closed 3 months ago

meissadia commented 3 months ago

Accessibility improvement

Changes

How to test this PR

  1. Load paginated table in an application (couldn't get ANDI to recognize the error in Storybook)
  2. Run ANDI accessibility tool
  3. Verify that it doesn't identify the following error
    • Element nested in <label> but label[for=m-pagination_current-page] does not match element [id=m-pagination_current-page-default

Screenshots

ANDI Before ANDI After
Screenshot 2024-05-24 at 3 32 30 PM Screenshot 2024-05-24 at 3 29 22 PM
netlify[bot] commented 3 months ago

Deploy Preview for cfpb-design-system-react ready!

Name Link
Latest commit 5aa9aaec02fd81841e8d1f7125baf4cdf15b3439
Latest deploy log https://app.netlify.com/sites/cfpb-design-system-react/deploys/66562372c6da750008a7198f
Deploy Preview https://deploy-preview-356--cfpb-design-system-react.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.