fix(Icon): Use BEM for Icon modifier classes

cfpb / design-system-react

A React/Storybook implementation of CFPB's Design System

https://cfpb.github.io/design-system-react/

MIT License

6 stars 4 forks source link

Closed meissadia closed 3 months ago

meissadia commented 3 months ago

I've confirmed that upgrading to the latest cfpb-icons library is the source of the breakage, causing the updating icons to no longer be animated
I've confirmed that other icon modifiers (ex. Success alert icon shown in green) seem to be working as expected.

netlify[bot] commented 3 months ago

Name	Link
Latest commit	ceaa542a8c2af9ab86efb6728cc44ee2d63c5850
Latest deploy log	https://app.netlify.com/sites/cfpb-design-system-react/deploys/665f52fe305dce0008c3d108
Deploy Preview	https://deploy-preview-364--cfpb-design-system-react.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

meissadia commented 3 months ago

@shindigira Thanks for the quick review! Requesting re-review because I needed to update broken unit tests.