cfpb / design-system-react

A React/Storybook implementation of CFPB's Design System
https://cfpb.github.io/design-system-react/
MIT License
6 stars 4 forks source link

fix(a11y): add explicit labels to alert icons #373

Open billhimmelsbach opened 2 months ago

billhimmelsbach commented 2 months ago

Often information is conveyed by the icons of our alerts (this is an error or warning, is this an external link) that is not conveyed explicitly by the text. These icons are then not presentational, and should be labeled.

Changes

How to test this PR

  1. Are the svgs now properly labeled on alerts, field level alerts, and alert links?

Screenshots

Screenshot 2024-06-28 at 4 46 36 AM

netlify[bot] commented 2 months ago

Deploy Preview for cfpb-design-system-react ready!

Name Link
Latest commit 89739e6198b012e1b5308aca205539b02dd948e5
Latest deploy log https://app.netlify.com/sites/cfpb-design-system-react/deploys/667ea19bbbc21c00089f7fd9
Deploy Preview https://deploy-preview-373--cfpb-design-system-react.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.