cfpb / design-system

CFPB's work-in-progress design system
https://cfpb.github.io/design-system
Creative Commons Zero v1.0 Universal
37 stars 12 forks source link

Update color palette accessibility checker #1226

Closed stephanieosan closed 2 years ago

stephanieosan commented 3 years ago

Which page is this about? Color

What kind of issue is this? Content/tech issue

Describe your issue The 3rd-party color palette accessibility checker we link to is no longer live (link throws a 500 error). We need to find an alternative to this, ideally that can replicate the behavior of our previous palette contrast checker. There are many color contrast tools available online but few of them support pre-loading them with a color palette, a feature we need.

Add any additional background info as needed

See the relevant discussion.

Should be updated on the following pages:

contolini commented 3 years ago

I loaded our colors into here: https://contrastchecker.com/?swatch_session=1612474035691

@anselmbradford @Scotchester Does the above link suffice?

Scotchester commented 3 years ago

I loaded our colors into here: https://contrastchecker.com/?swatch_session=1612474035691

@anselmbradford @Scotchester Does the above link suffice?

Unfortunately, I don't think so. It only shows each color on white. But loading every possible color combination at once would be ridiculous. (Also, wow, the sample text is tiny.)

natalia-fitzgerald commented 3 years ago

I pulled the relevant comments from the Mattermost chat on this from April 2021. The next step would be to access these options and select the one that best suits our needs.

Options @contolini posted:

Options @Scotchester posted:

sonnakim commented 2 years ago

I didn't see the original tool, but is this the kind of thing we're looking for? @nataliafitzgerald2 @contolini

Scotchester commented 2 years ago

I didn't see the original tool, but is this the kind of thing we're looking for? @nataliafitzgerald2 @contolini

❗ That looks awesome!!

sonnakim commented 2 years ago

Cool, thanks @scotchester! (We miss you!!)

natalia-fitzgerald commented 2 years ago

Hi @sonnakim I took a look at the tool and I have some thoughts. This tool does do a lot of what we would want but I wonder whether it provides so much information that the key information that a user would need to make a sound decision about their type would be lost. It is a pretty overwhelming output.

Some of the things I'd be looking for in our visualization:

I think it would make sense to simplify the output as much as possible in order to make it most applicable to the work. So I wonder whether a tool that includes only the most realistic combinations would be more helpful.

Maybe as a first step (MVP) we can use the tool that @sonnakim has populated so that in the near term we don't continue to have a dead link on the Design System page. And, as a next step we can try to develop something that is more specific to our goal of providing users with a tool for selecting type colors that have the proper contrast ratio AND are aligned with our brand guidelines and best practices.

sonnakim commented 2 years ago

@nataliafitzgerald I wonder if there's a limited number of type/background color combinations that are both brand complaint and accessible, and if so, perhaps we add them directly to the color page in the Design System. So, the next step would be to see how many combinations we're actually talking about. It may not be worth setting up a third party tool if it's easy enough to add these combinations directly to the Design System.

sonnakim commented 2 years ago

@nataliafitzgerald I think there are way too many color combinations for us to be able to add these manually to the DS...but I've looked more closely at the tool, and was thinking that for an MVP, maybe we can show three different links:

AA conformant combinations of:

Looking back at your comment, the issues with this MVP solution are, first, that the first two links above still show black and dark grey type on green, which is not brand compliant—but perhaps we can add these links to the Design System with a warning? And, second, that we still don't have a pixel translation for points. Anyway, let me know what you think.

caheberer commented 2 years ago

I'm curious if there's a more simplified solution. Personally, I never used the previous tool because I knew the general rule that black text on any of our colors at 20% and white text on any of our 100%+ saturation colors (except gold) is accessible. If I wanted to use a different color or tint I would check that combination individually on the WebAIM tool. It rarely comes up because as Natalia mentions above we don't recommend using colored type on a colored background, or even colored type much at all. Most colored type that we use are embedded in our patterns.

Would it be easier to provide general rules on the design system like this?

caheberer commented 2 years ago

During scrum we determined I would move forward with this proposed solution. Below is a mock-up of how I think the Fonts page could be updated to include more simplified guidance around accessible color combinations.

While we are at it, what do we think of changing the title of the page from "Fonts" to "Type"?

@sonnakim @designlanguage @ajbush mind letting me know what you think?

This would follow "Spacing" within the "Guidelines" section of the Fonts page. Color page mockup

sonnakim commented 2 years ago

@caheberer Nice! I like the simplicity and focus of what you've done here. It might be worth running this by one of the production designers as well to get their thoughts. Just a few small comments:


I like the idea of renaming the page to type — it does seem more appropriate. If you do rename it, I think we should add a redirect from the existing URL, as folks may be linking to this page from elsewhere. I think @brandon-rusk has handled redirects before, so you can let him know if you do rename it. I believe the nav will also have to be updated to link to the renamed page — that's something that you should have edit rights to do, but let me know if you run into issues.


image

Should we add the sentence "the only exception to colored type falls within illustration or other graphics" to the "Colored Type" section, and then add a jump link? Or combine these into one section? Otherwise it could sound like a contradiction. If there's a common enough use case for adding colored type in graphics, maybe we should make that clear, so there's no confusion.


image

I think "saturation of 100% and above" is a typo?


image

Should this say "Web Content Accessibility Guideline (WCAG) standards "? It's unusual to see "WCA" as a standalone acronym

caheberer commented 2 years ago

Thanks for the feedback, @sonnakim I'll work on incorporating your suggestions.

caheberer commented 2 years ago

Here's the revised version. @sonnakim let me know if you have any additional feedback. I'm going to ping additional designers/production designers to take a look as well.

Color page mockup .

sonnakim commented 2 years ago

@caheberer looks great!

caheberer commented 2 years ago

AJ reviewed and liked the simplicity. He also suggested incorporating the inclusion of "A few colors allow for slightly darker saturations while still maintaining accessibility." To cover the instances where we use darker saturations with black type, like in heroes.

I made the updates and published the page.