cfpb / design-system

CFPB's work-in-progress design system
https://cfpb.github.io/design-system
Creative Commons Zero v1.0 Universal
41 stars 13 forks source link

Fix `a-text-input` error/warning/success modifiers #1984

Closed anselmbradford closed 5 months ago

anselmbradford commented 5 months ago

https://github.com/cfpb/design-system/pull/1886 erroneously set the a-text-input error/warning/success modifiers to be blocks, apparently because of a mistake I made reconciling conflicts in https://github.com/cfpb/design-system/pull/1886/commits/6f6bbbbc307f1e5dccc7e6b8f9a90fa196743294

https://github.com/cfpb/design-system/pull/1983/ updated the example to follow the CSS, but the CSS should actually be updated to retain these as modifiers instead of erroneously as blocks.

Changes

Testing

  1. Text inputs should have error/warning/success colored border styling on https://deploy-preview-1984--cfpb-design-system.netlify.app/design-system/components/text-inputs
netlify[bot] commented 5 months ago

Thanks for the improvements! Browse a preview of your changes using the link below.

Name Link
Latest commit 9522b819a55c8dad12491e5f062f23c6e8c24462
Latest deploy log https://app.netlify.com/sites/cfpb-design-system/deploys/6655d63d352d7b000816d495
Deploy Preview https://deploy-preview-1984--cfpb-design-system.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.