cfpb / design-system

CFPB's work-in-progress design system
https://cfpb.github.io/design-system
Creative Commons Zero v1.0 Universal
37 stars 12 forks source link

Remove `a-link--no-wrap`, `a-link-icon`, and `m-list__link` #1989

Closed anselmbradford closed 3 months ago

anselmbradford commented 3 months ago

Removals

Changes

Testing

  1. Visit https://deploy-preview-1989--cfpb-design-system.netlify.app/design-system/components/links#list-link and see that the list of jump links looks correct across screen sizes.

Screenshots

Screenshot 2024-05-30 at 12 23 29 PM Screenshot 2024-05-30 at 12 23 50 PM
netlify[bot] commented 3 months ago

Thanks for the improvements! Browse a preview of your changes using the link below.

Name Link
Latest commit e17a32be05fab2b7ab4f0fbf5b476645e634faa2
Latest deploy log https://app.netlify.com/sites/cfpb-design-system/deploys/6658c98f9dc7060008c6f8e3
Deploy Preview https://deploy-preview-1989--cfpb-design-system.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

anselmbradford commented 3 months ago

Cool. I wonder if "jump links" are still a good name for this pattern. Makes me think there's anchor-linking behavior built in, but that's not really what it's about.

It's a good question!