Set underline on link by default

cfpb / design-system

CFPB's work-in-progress design system

https://cfpb.github.io/design-system

Creative Commons Zero v1.0 Universal

37 stars 12 forks source link

Set underline on link by default #1990

Closed anselmbradford closed 3 months ago

anselmbradford commented 3 months ago

https://github.com/cfpb/design-system/pull/1989 removed a-link--icon, but that means the underline goes right under the icon. This PR makes a-link, but default run the underline only under the text, and not an accompanying icon.

Changes

Set underline on link by default

Testing

https://deploy-preview-1990--cfpb-design-system.netlify.app/design-system/components/links#link-with-icon should not have a line under the icon.

Screenshots

netlify[bot] commented 3 months ago

Thanks for the improvements! Browse a preview of your changes using the link below.

Name	Link
Latest commit	75480d1d3494d68cd7c036e8fccc907165d97703
Latest deploy log	https://app.netlify.com/sites/cfpb-design-system/deploys/6658db6724ba7f00089e4d4a
Deploy Preview	https://deploy-preview-1990--cfpb-design-system.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.