search

cfpb / design-system

CFPB's work-in-progress design system
https://cfpb.github.io/design-system
Creative Commons Zero v1.0 Universal
37 stars 12 forks source link

Set banner link colors #2004

Closed anselmbradford closed 1 month ago

anselmbradford commented 1 month ago

Visited links in the dark banner were meant to be white according to the thread in https://github.com/cfpb/design-system/pull/1387/, but this didn't make it in.

Changes

Testing

  1. Visit the PR preview banners page and click a link in the dark banner and reload the page to see that the visited link color is white.

Screenshots

Before:

Screenshot 2024-07-26 at 2 37 12 PM

After:

Screenshot 2024-07-26 at 2 39 04 PM
netlify[bot] commented 1 month ago

Thanks for the improvements! Browse a preview of your changes using the link below.

Name Link
Latest commit 574e46b1fe150106a2358831c203e8a6e17e02bd
Latest deploy log https://app.netlify.com/sites/cfpb-design-system/deploys/66a3ed7044a98d0008621856
Deploy Preview https://deploy-preview-2004--cfpb-design-system.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

anselmbradford commented 1 month ago

Unrelated to this PR, the links should be underlined/bordered to stay accessible, no?

Hmmm good catch. I'll look into it.