search

cfpb / django-flags

Feature flags for Django projects
https://cfpb.github.io/django-flags/
Creative Commons Zero v1.0 Universal
256 stars 31 forks source link

Remove print leftover in the urlpatterns code. #113

Closed Natim closed 1 year ago

Natim commented 1 year ago

@chosak can you also take a look at the PR dropping support for Python3.6? Tests are not passing anymore with this arch on Github actions which prevents it to be merged.

chosak commented 1 year ago

@Natim yes, we'll take care of those - it seems like there are some linter failures unrelated to your PR as well.

adamchainz commented 1 year ago

Hehe I also removed the print in the unmerged Django 4.2 PR: https://github.com/cfpb/django-flags/pull/110#discussion_r1167094559

willbarton commented 1 year ago

@Natim @adamchainz Thanks! I'll get these PRs reconciled and the linting/test issues fixed this morning. A patch release will go out after that!

Natim commented 1 year ago

That would be awesome :pray: thanks :1st_place_medal:

willbarton commented 1 year ago

Combined and merged in https://github.com/cfpb/django-flags/commit/c95721e559bcc4fbfaa30e007e4a9ec2d7a17218 and https://github.com/cfpb/django-flags/commit/2667995ce649914a0bfecc0b18e1f42f9515b70a

willbarton commented 1 year ago

Thank you so much for the contribution, @Natim!!