search

cfpb / generator-cf

Yeoman generator for Capital Framework
http://cfpb.github.io/capital-framework/getting-started/
Creative Commons Zero v1.0 Universal
9 stars 13 forks source link

Initial release #1

Closed contolini closed 9 years ago

contolini commented 9 years ago

@himedlooff Please review when you have a sec. It still needs some work but I think we have a solid foundation. It scaffolds an application similar in structure to cfgov-refresh and installs selected bower components. I'd like to publish it to npm sooner than later to reserve the yo cf namespace.

Still to do:

himedlooff commented 9 years ago

@contolini did you use the OS files from here? https://github.com/cfpb/open-source-project-template That's where we've been pulling from for Cf components.

contolini commented 9 years ago

@himedlooff I responded to everything above and copied over the default files from https://github.com/cfpb/open-source-project-template. Let me know if there's anything else.

himedlooff commented 9 years ago

Why is this included? app/templates/specs/js/vendor/jquery-1.9.1.js

contolini commented 9 years ago

@himedlooff Dunno. Probably cruft from cf-demo or cfgov-refresh. I think I'm gonna kill the entire specs directory. Seems unnecessary.

contolini commented 9 years ago

Pushed some updates. Note: The goal of this initial release is to generate standard boilerplate files. Grunt is only half hooked-up. Subsequent PRs will fix that.

himedlooff commented 9 years ago

@contolini, the only thing is that I'm now realizing that the root level files are specific to the generator. Can you make sure the files in the app/templates folder are updated? Like the ignore, terms, contrib, etc...

Scotchester commented 9 years ago

It's cool, the ones for the generated needed updating, too :)

contolini commented 9 years ago

@himedlooff I left out the license, terms, contributing, etc. because they're dependent upon the license chosen by the user. I like @Scotchester's idea of pulling them in from https://github.com/cfpb/open-source-project-template so that we're always using the latest version. See #3.

himedlooff commented 9 years ago

@contolini, agh ok thanks sorry, is this ready for merging then?

contolini commented 9 years ago

@himedlooff It's ready by my standards. Lots of improvements to be made down the road.

contolini commented 9 years ago

Published: https://www.npmjs.org/package/generator-cf

ascott1 commented 9 years ago

:clap: