cfpb / generator-cf

Yeoman generator for Capital Framework
http://cfpb.github.io/capital-framework/getting-started/
Creative Commons Zero v1.0 Universal
9 stars 13 forks source link

Port build processes over to voltrazord #107

Closed contolini closed 8 years ago

contolini commented 8 years ago

Generator changes per last week's pairing. Let me know how it works out.

Added

Scotchester commented 8 years ago

Code looks good. Pulling down for a local test now.

Scotchester commented 8 years ago

Update to fix the earlier identified issue pushed. @contolini Can you pull this down and try a fresh generation and see if it works as expected? Also see if you run into that hanging issue.

contolini commented 8 years ago

Niiiiice! Both the grunt and gulp versions build without errors for me. And the generated dist directories look A-OK. Even the pesky icons are loading correctly.

contolini commented 8 years ago

Mergin' and publishin'.

Scotchester commented 8 years ago

Just to double-check: Do you mean that you ran the generator and it didn't hang just before running setup.sh?

contolini commented 8 years ago

Correct. :+1:

Scotchester commented 8 years ago

Cool. Must've been a local issue for me.