cfpb / generator-cf

Yeoman generator for Capital Framework
http://cfpb.github.io/capital-framework/getting-started/
Creative Commons Zero v1.0 Universal
9 stars 13 forks source link

gulp-less error on webfont rules in main.less sample styles #137

Closed niqjohnson closed 6 years ago

niqjohnson commented 7 years ago

The gulp-less task throws an error when the Yeoman generator first tries to build the project (and on any subsequent gulp build, too).

Current behavior

At the end of the yo cf process, the build script (gulp, in this case) builds the project. Looks like there are some undefined LESS mixins in the sample styles in main.less that are causing an error in gulp-less.

Expected behavior

All the gulp tasks should run without errors. Looks like the webfont rules in the sample styles just need to be prefixed with u- to work right.

Steps to replicate behavior

  1. Update the Yeoman Capital Framework generator to the latest version
  2. yo cf
  3. Enter anything for all the setup questions
  4. Select all CF components
  5. Select gulp as the build tool
  6. Wait for the generator to start running gulp build
  7. Note the error: .webfont-medium is undefined in file /[path]/src/static/css/main.less line no. 41
  8. If you comment out line 41, a similar error will happen for the .webfont-regular mixin on lines 58 and 121 of main.less, too.

Screenshots

terminal

jimmynotjim commented 7 years ago

@niqjohnson thanks for finding this, I messed up in the CFv4 upgrade and missed a few things. I'll get this fixed.

anselmbradford commented 6 years ago

This may be fixed?

jimmynotjim commented 6 years ago

Yep, we've completely removed the web font mixins from CF.

Scotchester commented 6 years ago

The original issue was closed by @anselmbradford in https://github.com/cfpb/generator-cf/commit/0d6fb5fa4129fafa35897bdd341523db38a37663#diff-58b52ce1dd4b9183b07d419539316086

@jimmynotjim We'll also need to remove the webfont mixins from the sample main.less file now that we're deprecating them.

jimmynotjim commented 6 years ago

Addressed in #149