cfpb / generator-cf

Yeoman generator for Capital Framework
http://cfpb.github.io/capital-framework/getting-started/
Creative Commons Zero v1.0 Universal
9 stars 13 forks source link

Improve Bower failure handling #30

Closed Scotchester closed 9 years ago

Scotchester commented 9 years ago

During initial generation, if the Bower install step fails (say, for example, you're not connected to the VPN and can't SSH to GitHub from inside the building... :expressionless:), you have no way to recover other than blowing it away and starting fresh.

It'd be better if the dependencies could be added to the bower.json file first, and then they'll be installed with the postinstall script when running npm install here.

(Relatedly, isn't the bower install piece of that postinstall script redundant, since compile-cf runs the bower:cf Grunt task?)

contolini commented 9 years ago

Cool, some notes from our in-person discussion:

jimmynotjim commented 9 years ago

@Scotchester compile-cf doesn't install the dependencies, it's set to false.

@contolini what is your bullet on writing the config options related to?

I've got a somewhat working update at #52 but I'm not sure what's the best way to get the latest version, any ideas? My initial thought was to grab them when we grab the list of components during the init. Is there something simpler I'm missing?

Scotchester commented 9 years ago

@jimmynotjim Oh yeah, good point.

Yeah, getting the latest when grabbing the list makes sense to me.

jimmynotjim commented 9 years ago

52 is now working and with bower install is run as an NPM post install script it should error out leaving you with the option to re-run bower install on your own.

jimmynotjim commented 9 years ago

52 fixes this issue, closing it out.