The demo page and main.less file should be more dynamic

cfpb / generator-cf

Yeoman generator for Capital Framework

http://cfpb.github.io/capital-framework/getting-started/

Creative Commons Zero v1.0 Universal

9 stars 13 forks source link

The demo page and main.less file should be more dynamic #34

Open himedlooff opened 9 years ago

himedlooff commented 9 years ago

For example if you don't choose all of the components you could get an error for missing variables. Also you will still see the demo markup for that component which will be un-styled. We should also update the theme overrides less file as well to exclude variables for components you haven't asked for.

Scotchester commented 9 years ago

:+1:

KimberlyMunoz commented 9 years ago

Ran into a missing variable problem for @super-btn-font-size in src/static/css/cf-theme-overrides.less when I didn't select buttons as a component.

himedlooff commented 9 years ago

Good catch @KimberlyMunoz. @Scotchester fixed this issue here: https://github.com/cfpb/generator-cf/pull/35

You can make the same change locally. Let me know if this solves it for you.