cfpb / generator-cf

Yeoman generator for Capital Framework
http://cfpb.github.io/capital-framework/getting-started/
Creative Commons Zero v1.0 Universal
9 stars 13 forks source link

Support Existing Projects #39

Closed jimmynotjim closed 9 years ago

jimmynotjim commented 9 years ago

Added check for an existing project

Additions

None

Removals

None

Changes

None

Notes

contolini commented 9 years ago

:+1: This feature is a great idea.

jimmynotjim commented 9 years ago

It's not the author name it's failing at, it's the package name on L:53 (though you're definitely right about the additional author check).

jimmynotjim commented 9 years ago

Sweet it's fixed!

The one downside is that I'm finding is some of our projects use package.json and some bower.json. For example, OaH Bower manifest doesn't have much while the Node manifest is complete. For CFGov Refresh the Bower manifest is complete but the Node manifest is not. There's going to be some manual reconciliation for any projects that are utilizing bower.json instead of package.json.

Also, you have to be really aware when committing if you respond yes to overwriting files. Some of the overwrites you'll want (like version updates we've cleared), but if you've added Node or Bower packages to your project they'll be removed.

contolini commented 9 years ago

Cool, this is a great enhancement. Let's keep an eye on things to see how it works for folks.

ascott1 commented 9 years ago

:heart: this.

jimmynotjim commented 9 years ago

Ran this on cfgov-refresh to get that project updated and it's currently going well. Bit of manual tweaks to match the project specifically but DiffMerge makes that easier.