Closed jimmynotjim closed 9 years ago
Oh, that makes it more clear why core was left out: Because it's required for CF to be useful at all, we didn't want it to be deselectable in the startup script.
Even if you de-select it at the prompt, it'll still be installed, which is why I find it kind of odd being there. Maybe we just tack it on to the list after the prompt has finished?
Could you just change the wording on the prompt to something like:
You're about to install CF Core. Which additional CF components would you like in your app?
@anselmbradford I kind of like that combined with my idea of tacking it on. I'd still like to see it in the generated bower.json, but that message makes it clear that core will be installed by default no matter what.
I took @anselmbradford’s suggestion and updated the components message and manually added cf-core to the user’s provided options. This solves the issue of possibly de-selecting cf-core while also providing clarity on what steps the user is about to take.
I'd like to squash out that commit changing the ignore file. Let me know if we're good to go before merging this and I'll do that.
:+1:
Ok, ready to merge from my side once it passes Travis CI again.
Adds cf-core to bower dependency list
Additions
None
Removals
None
Changes
Testing
bower.json
for cf-core as listed dep/src/vendor
for cf-core for proper installationReview
Preview
Notes