cfpb / generator-cf

Yeoman generator for Capital Framework
http://cfpb.github.io/capital-framework/getting-started/
Creative Commons Zero v1.0 Universal
9 stars 13 forks source link

Adds cf-core to bower dependency list #48

Closed jimmynotjim closed 9 years ago

jimmynotjim commented 9 years ago

Adds cf-core to bower dependency list

Additions

None

Removals

None

Changes

screen shot 2015-03-24 at 5 10 53 pm

Notes

Scotchester commented 9 years ago

Oh, that makes it more clear why core was left out: Because it's required for CF to be useful at all, we didn't want it to be deselectable in the startup script.

jimmynotjim commented 9 years ago

Even if you de-select it at the prompt, it'll still be installed, which is why I find it kind of odd being there. Maybe we just tack it on to the list after the prompt has finished?

anselmbradford commented 9 years ago

Could you just change the wording on the prompt to something like:

You're about to install CF Core. Which additional CF components would you like in your app?

jimmynotjim commented 9 years ago

@anselmbradford I kind of like that combined with my idea of tacking it on. I'd still like to see it in the generated bower.json, but that message makes it clear that core will be installed by default no matter what.

jimmynotjim commented 9 years ago

I took @anselmbradford’s suggestion and updated the components message and manually added cf-core to the user’s provided options. This solves the issue of possibly de-selecting cf-core while also providing clarity on what steps the user is about to take.

jimmynotjim commented 9 years ago

I'd like to squash out that commit changing the ignore file. Let me know if we're good to go before merging this and I'll do that.

Scotchester commented 9 years ago

:+1:

jimmynotjim commented 9 years ago

Ok, ready to merge from my side once it passes Travis CI again.