cfpb / generator-cf

Yeoman generator for Capital Framework
http://cfpb.github.io/capital-framework/getting-started/
Creative Commons Zero v1.0 Universal
9 stars 13 forks source link

Write deps to bower.json #52

Closed jimmynotjim closed 9 years ago

jimmynotjim commented 9 years ago

Writing CF component dependencies to the bower file

Additions

None

Removals

None

Changes

screen shot 2015-03-25 at 2 46 59 pm

Notes

jimmynotjim commented 9 years ago

I added an API call to the tags endpoint for each chosen component and updated the bower.json for the new this.components array. Not sure if this is the cleanest solution, but it's the only way I could find that avoided erroneous API calls and worked with async instead of against it.

**There are now conflicts from the other work today, once this is OK'd I'll squash everything and then pull down the upstream changes

Scotchester commented 9 years ago

Looks good to me. Squash it up!

Scotchester commented 9 years ago

Ready for merge?

jimmynotjim commented 9 years ago

Yes it is, thanks.