Switching GitHub API to search endpoint - Githubissues

cfpb / generator-cf

Yeoman generator for Capital Framework

http://cfpb.github.io/capital-framework/getting-started/

Creative Commons Zero v1.0 Universal

9 stars 13 forks source link

Switching GitHub API to search endpoint #53

Closed jimmynotjim closed 9 years ago

jimmynotjim commented 9 years ago

Switching GitHub API to search endpoint for better speed and simplicity

Additions

None

Removals

None

Changes

updated API url to search enpoint with filtering params included
updated filter components to use new json object (repos are now in a child array of items)
Testing
fetch and run npm link
run yo cf in a test project directory
should be a noticeable difference in initial app ramp up time
same components as always should be displayed at prompt
Review
@contolini
@ascott1
@Scotchester
@KimberlyMunoz
@himedlooff
Preview

None

Notes

using search endpoint reduces total number of requests (we now have over 100 repos)
using search endpoint greatly reduces request times (removes about 1-2 sec from initial ramp up)
using search endpoint allows us to push the filtering on to GitHub rather than our app’s logic
mocha tests not available due to components not being written to bower.json (see #52)

jimmynotjim commented 9 years ago

Squashed and ready for merge after Travis CI passes

Scotchester commented 9 years ago

:+1: