search

cfpb / generator-cf

Yeoman generator for Capital Framework
http://cfpb.github.io/capital-framework/getting-started/
Creative Commons Zero v1.0 Universal
9 stars 13 forks source link

Why isn't proposed brand color in cf-enhancements #59

Closed anselmbradford closed 9 years ago

anselmbradford commented 9 years ago

@dark-redorange is listed as an // Unofficial or proposed colors in https://github.com/cfpb/generator-cf/blob/master/app/templates/src/static/css/brand-palette.less#L30

Shouldn't it be in https://github.com/cfpb/generator-cf/blob/master/app/templates/src/static/css/cf-enhancements.less instead?

Also, what's the migration path to make it an official color?

Scotchester commented 9 years ago

Because that line of code goes back almost two years to well before cf-enhancements existed :)

I don't think it needs to be made an official color. It only really has one use: active state on destructive actions.

anselmbradford commented 9 years ago

Because that line of code goes back almost two years to well before cf-enhancements existed :)

I don't think it needs to be made an official color. It only really has one use: active state on destructive actions.

Kind of sounds like it already is an official color if it's in use for two years? What makes a color "official" vs not?

Scotchester commented 9 years ago

What makes a color "official" vs not?

Whether or not it appears here: http://cfpb.github.io/design-manual/identity/color-principles.html

anselmbradford commented 9 years ago

Ahh, would it make sense to have https://github.com/cfpb/generator-cf/blob/master/app/templates/src/static/css/brand-palette.less#L6 link to that?

Scotchester commented 9 years ago

Yeah, it would. Good call! Should've revisited that when the Design Manual was released.

anselmbradford commented 9 years ago

What's the canonical source of brand-palette.less? Is it this repo?

Scotchester commented 9 years ago

I believe so; see also: cf-theme-overrides.less.