search

cfpb / generator-cf

Yeoman generator for Capital Framework
http://cfpb.github.io/capital-framework/getting-started/
Creative Commons Zero v1.0 Universal
9 stars 13 forks source link

Change bower:cf task name to bower:process #68

Closed anselmbradford closed 9 years ago

anselmbradford commented 9 years ago

See https://github.com/cfpb/generator-cf/blob/master/app/templates/_Gruntfile.js#L34

Why is this task called bower:cf? It appears to install all bower dependencies from bower.json, not just cf packages. This is currently called "install" in cfgov-refresh and OAH and I'm just wondering if it was intentionally changed to cf for some reason I'm not seeing?

contolini commented 9 years ago

generator-cf's bower task is a little different from cfgov-refresh's. The generator implemented these changes proposed by @himedlooff a while back. I think I changed the name from install to cf because the task no longer installs the bower components (see line 37). It mostly just cleans up the components folder.

You're right, though, that it doesn't only touch CF components so cf is a misnomer. Maybe we should change it to something like bower:process?

jimmynotjim commented 9 years ago

cfgov-refresh will also be updating in the future to match the generator. There's no reason to re-install every package, that's what the manager is there for. process sounds like a fine task name to me.

anselmbradford commented 9 years ago

Cool I'll go with process for the update to cfgov-refresh gruntfile I'm working on. That link @contolini posted gives great context for the two vendor directories too. Looks like they could be consolidated.

contolini commented 9 years ago

Be gone ye bower task!

tumblr_mdemydvxpq1qedb29o1_500