search

cfpb / generator-cf

Yeoman generator for Capital Framework
http://cfpb.github.io/capital-framework/getting-started/
Creative Commons Zero v1.0 Universal
9 stars 13 forks source link

Consider renaming pkg variable in Gruntfile #70

Closed anselmbradford closed 8 years ago

anselmbradford commented 9 years ago

The pkg variable in the Gruntfile really makes it seem like it's referencing package.json, when in fact it's referencing bower.json. Even the code comment thinks it's package.json. Can this have either a bower-specific name or a more general name like metadata or equivalent?

jimmynotjim commented 9 years ago

We could reference the package.json instead of bower.json like most generators do. Generated projects have complete manifests for both managers so there's no reason not to.

anselmbradford commented 8 years ago

This now references package.json https://github.com/cfpb/generator-cf/blob/master/app/templates/grunt/_Gruntfile.js#L24