cfpb / generator-cf

Yeoman generator for Capital Framework
http://cfpb.github.io/capital-framework/getting-started/
Creative Commons Zero v1.0 Universal
9 stars 13 forks source link

bower task should have `verbose` set to `false` #75

Closed anselmbradford closed 9 years ago

anselmbradford commented 9 years ago

Bower packages are manually installed in src/vendor in https://github.com/cfpb/generator-cf/blob/master/app/templates/bowerrc

Bower Grunt task targets the same directory (which it needs to because install: false is set), so what ends up happening is all the bower packages are copied over themselves in the same directory.

The copy: false flag should be set on the task.

anselmbradford commented 9 years ago

Err nevermind, if the packages aren't copied they will never be processed by https://github.com/cfpb/generator-cf/blob/master/app/templates/_Gruntfile.js#L40. Instead how about turning off the verbose flag at https://github.com/cfpb/generator-cf/blob/master/app/templates/_Gruntfile.js#L38 so there isn't output of the packages being copied to their same location. If so feedback at the command-line is needed, a grunt.log.writeln(…) message could be added in the layout loop.

anselmbradford commented 9 years ago

verbose can even be left off because the default is false.

contolini commented 9 years ago

the bower task has been removed