cfpb / generator-cf

Yeoman generator for Capital Framework
http://cfpb.github.io/capital-framework/getting-started/
Creative Commons Zero v1.0 Universal
9 stars 13 forks source link

Align installed eslint version and eslint file #78

Open anselmbradford opened 9 years ago

anselmbradford commented 9 years ago

Package.json in the generator pulls a specific version of eslint through grunt-eslint https://github.com/cfpb/generator-cf/blob/master/app/templates/_package.json#L28 (0.19.0), however, the front-end repo has been updated to work with the latest version (0.21.0). Either generator-cf should pull in the latest grunt-eslint with "grunt-eslint": "latest" (I believe that's the syntax?) or, safer, it should pull a specific version of the lint file with that's pegged against the version of eslint installed, e.g. pulling in https://github.com/cfpb/front-end/blob/53b7d38df6e91d03bd7e4839d489fccd680a58fc/.eslintrc ... not pegging the lint file and the eslint version installed against each other always risks that one or the other introduces breaking changes as the versions increment (as is currently the case in generator-cf).