Updating Changelog

[KimberlyMunoz]

Just updating the changelog from #69 to tag.

Review

• @ascott1

[Scotchester]

Sorry I didn't catch this in the PR with the actual changes, but I don't think we should have these overrides in place by default. We'll still have the problem that any (third party) who runs the generator will be trying to use our Avenir Next webfonts right out of the gate.

I think we should comment out the @import and the @webfont- variables, and make people uncomment them to use them.

[KimberlyMunoz]

I thought the issue was that we wanted to separate out the CFPB brand variables in general and that includes the webfonts.

Would it make more sense to link these in the brand-palette.less and then that can be commented out as necessary?

[Scotchester]

That was the main issue, yes, but also it doesn't make sense for that to be the default, because unless someone's got access to one of the domains on our whitelist, the fonts won't load, and they'll be making four useless HTTP requests.

I think they belong more in cf-theme-overrides than brand-palette. My reasoning is that brand-palette is more of a helper, where cf-theme-overrides is considered more essential. The @import for the webfonts might make more sense in main.less, actually?

[KimberlyMunoz]

I'll bug you on chat tomorrow and let's figure it out.

I like the idea to include @import in main.less. It makes it much more obvious to comment out or un-comment out.

[contolini]

LMK if you two need help hashing this out.

[KimberlyMunoz]

Ready for you to take a look, @Scotchester.

[Scotchester]

:+1: Thanks!

[Scotchester]

Please tag and release.

[KimberlyMunoz]

:+1: Done.