Update generator logic to support CF v1.x.x

[contolini]

Uses the new @import technique instead of concatenating the cf- files.

Added

• Checks author's email to determine if they're a CFPB employee and uncomments licensed-fonts.css if they are.
• Adds clean task to delete the dist dir before recreating it.

  Changed

• If user selects every component, install capital-framework instead of every component individually.
• Fixes async bug that was preventing final goodbye message from being echoed.
• Updated all dev dependencies in package.json to latest versions.
• Adds carets in front of CF components' version numbers in bower.json.
• Updates changelog appropriately.

  Removed

• Grunt bower and concat-cf tasks.
• exportsOverride section in bower.json.

  Testing

• Pull down these changes and follow the contributing steps.
• Generate a new project. Provide an author's email of "foo@bar.com" and select all available CF components. The generated src/static/css/main.less file should:
  • Have @import (less) 'licensed-fonts.css' commented out because it doesn't think you're a CFPB employee.
  • Import "../../vendor/capital-framework/src/capital-framework.less" because it knows you want the entire framework.
• Generate a new project. Provide your CFPB email as the author's email and select only one or two CF components. The generated src/static/css/main.less file should:
  • Have @import (less) 'licensed-fonts.css' NOT commented out because it detected "cfpb.gov" in your email address and assumes you're a CFPBer.
  • Import each selected component on a separate line.

    Review

• @Scotchester
• @jimmynotjim
• @anselmbradford

  Notes

This PR has some strong opinions. Notably, the removal of the grunt bower task and related exportsOverride section of bower.json. That grunt task has always felt ugly and esoteric to me. It's not easy to determine what it does without studying the task's docs.

The result is that the directories in src/vendor are now populated with the full contents of the dependencies' repos instead of just their "main" files. I don't view this as a problem because it's Bower's default behavior and it's how other managers like npm do it. I know others liked that task, though, so please voice any concerns.

[ascott1]

Checks author's email to determine if they're a CFPB employee and uncomments licensed-fonts.css if they are.

[anselmbradford]

This PR has some strong opinions. Notably, the removal of the grunt bower task and related exportsOverride section of bower.json. That grunt task has always felt ugly and esoteric to me. It's not easy to determine what it does without studying the task's docs.

Yay! I too felt this task is hard to follow and it's probably best to move away from a plugin that has been looking for a maintainer for nearly a year. I can test later, but I just wanted to check on two things related to this task:

• box-sizing-polyfill is installed by cf-grid, which expects it to be in /static/vendor/, when the Gruntfile moves the box-sizing-polyfill here will it end up in /dist/static/ or /dist/static/vendor/? That is, does the copy task include the directory it found the file in when it performs the copy or will it just move the file without the underlying structure?
• In flapjack we still had to move html5shiv because that's not concatenated with the rest of the JS since it needs to be loaded before other scripts load. Is it a problem that it's not being moved anymore?

[contolini]

@anselmbradford Cool, good to know someone else wasn't a fan of that task!

box-sizing-polyfill is installed by cf-grid, which expects it to be in /static/vendor/, when the Gruntfile moves the box-sizing-polyfill here will it end up in /dist/static/ or /dist/static/vendor/? That is, does the copy task include the directory it found the file in when it performs the copy or will it just move the file without the underlying structure?

The copy task includes the directory so we should be good here.

In flapjack we still had to move html5shiv because that's not concatenated with the rest of the JS since it needs to be loaded before other scripts load. Is it a problem that it's not being moved anymore?

Hmmm, I noticed that bower wasn't downloading html5shiv so I deleted that task. It's possible I erroneously deleted that dependency from one of the CF components when I did all the v1 changes. Do you know which component requires it?

[anselmbradford]

Hmmm, I noticed that bower wasn't downloading html5shiv so I deleted that task. It's possible I erroneously deleted that dependency from one of the CF components when I did all the v1 changes. Do you know which component requires it?

hm, I'm actually not sure that CF requires it, so this may be fine. It could just be that flapjack was using it. If there are any semantic HTML elements in use in CF they would require it I suspect.

[sephcoster]

I know you didn't ask - but, changes look good to me. Any changes that result in a passing build after generation while not being prescriptive about included things above and beyond what's needed seems good to me! :+1:

[contolini]

Cool, I anticipate patches coming after this but let's kick the tires.

[contolini]

Tagged and published. Run yo and select "Update your generators".