search

cfpb / generator-cf

Yeoman generator for Capital Framework
http://cfpb.github.io/capital-framework/getting-started/
Creative Commons Zero v1.0 Universal
9 stars 13 forks source link

Add gulp option #91

Closed contolini closed 8 years ago

contolini commented 8 years ago

From @jimmynotjim in https://github.com/cfpb/front-end/issues/56#issuecomment-130360744

If no one objects, I'll take this on. I've implemented the same Grunt/Gulp choice in the WP Evolved generator so it won't be difficult to do the same to the CF generator.

jimmynotjim commented 8 years ago

Almost done with this but I'm unsure if I should be including browserify by default since a few of our projects are now using it and it seems to be the best way to package scripts as needed. Any opinions?

ascott1 commented 8 years ago

I would :+1: to browserify, but let's make that part of it's own PR.

contolini commented 8 years ago

Making it the default sounds good to me.

Scotchester commented 8 years ago

If it's made the default, let's please just make sure the instructions for adding one's own JS and adding new modules to the project are easy and clear.

jimmynotjim commented 8 years ago

Progress, just need to remove browserify (it is well embedded in our workflow at this point).

https://github.com/cfpb/generator-cf/compare/master...jimmynotjim:gulp-option?expand=1

jimmynotjim commented 8 years ago

Or, should we add Browserify to the Grunt workflow first, then continue down the Gulp path?

jimmynotjim commented 8 years ago

:musical_note: It finally happened, it finally happened, oh yes :musical_note:

Check the PR

jimmynotjim commented 8 years ago

Released!!!