search

cfpb / generator-cf

Yeoman generator for Capital Framework
http://cfpb.github.io/capital-framework/getting-started/
Creative Commons Zero v1.0 Universal
9 stars 13 forks source link

add new label style var #96

Closed cfarm closed 8 years ago

cfarm commented 8 years ago

add new color variable for new form label element.

see https://github.com/cfpb/cf-forms/pull/38 for details

jimmynotjim commented 8 years ago

:+1: but now I have a thought, can we pull this file from the capital-framework repo rather than duplicating the work?

Scotchester commented 8 years ago

Yes, it would definitely be better to only maintain it in one place. I just now realized it was in capital-framework; I thought that the generator was the canonical source. I think we have some changes here in the generator repo that haven't made it to capital-framework.

I may have shared this idea before, but I've been wondering if we should create a "theming" mechanism for CF, so we could pull out this file, brand-palette.less, and licensed-fonts.css into their own repo that is clearly the canonical source.

Scotchester commented 8 years ago

Anyway, :+1: for now.

ascott1 commented 8 years ago

create a "theming" mechanism for CF, so we could pull out this file, brand-palette.less, and licensed-fonts.css into their own repo that is clearly the canonical source

+1 to this idea

jimmynotjim commented 8 years ago

Does it need to be yet another repo? Could it be in the parent CF repo once we figure out what does and doesn't need to be available through NPM?

Scotchester commented 8 years ago

That would be an immediate improvement, @jimmynotjim, but I think we want to get to the separate theme repo setup in the future, so that third parties grabbing CF don't all get our styling by default.