cfpb / github-wiki-search

:warning: DEPRECATED :warning:
Creative Commons Zero v1.0 Universal
7 stars 17 forks source link

Change path to path_analyzed in ES query #101

Closed dpford closed 9 years ago

dpford commented 9 years ago

Previously, the ES query being generated was filtering by "path", but the correct field is "path_full". This makes that change.

dgreisen-cfpb commented 9 years ago

shouldn't it be path_analyzed, not path_full, to get the tree functionality?

dgreisen-cfpb commented 9 years ago

actually, I think it should be path.path_analyzed. See: https://github.com/cfpb/github-wiki-search/blob/fb2dc1ae13353bc4009bac261fd1b4180fadc4cb/client/src/static/js/app.js

dpford commented 9 years ago

Ah, good call. path_full works for when the full path is entered. path_analyzed works for both the full path and the first part of it (e.g. /cfpb). I didn't see a difference between path.path_analyzed and just path_analyzed, in terms of ES results.

dgreisen-cfpb commented 9 years ago

looks good.