search

cfpb / grasshopper-parser

Address Parsing REST API
Creative Commons Zero v1.0 Universal
8 stars 8 forks source link

Removes POST from /parse #13

Closed hkeeler closed 9 years ago

hkeeler commented 9 years ago

Closes #12.

This is dependent on #7. Please review/merge that one first.

wpears commented 9 years ago

References to POST need to be pulled out of the README to keep it in sync.

wpears commented 9 years ago

Which would also be a good time to fix the first line of the /parse section

The /parse resource is the heart of this API. It parses a free-text address strings into their component parts.

Should be have the a removed, resulting in:

The /parse resource is the heart of this API. It parses free-text address strings into their component parts.
wpears commented 9 years ago

Also looks like this needs to be rebased off upstream/master.

Though we can merge in https://github.com/cfpb/grasshopper-parser/pull/10 first so we don't have to possibly rebase twice.

wpears commented 9 years ago

:+1: An preference on on whether this gets merged before #10 now?

hkeeler commented 9 years ago

Nice, +2.78% coverage by removing code. I should remove more until I get to 100%. :)

Nope. Shouldn't matter if we merge this before #10. Merge away.