search

cfpb / grasshopper

CFPB's streaming batch geocoder
Creative Commons Zero v1.0 Universal
37 stars 13 forks source link

Addressnumber string #136

Closed jmarin closed 9 years ago

jmarin commented 9 years ago

Accounts for address ranges that are not numeric. So far the following cases have been contemplated as per the TIGER/Line geocoding documentation

  1. Address ranges can include numbers with alphabetic characters (i.e. G1-G99)
  2. Some address systems use a hyphen to separate avenue numbers, private road designators, and grid cell numbers from the structure numbers (i.e. 10-01)
hkeeler commented 9 years ago

Checking this out now. Reading up on ScalaTest's Property-based Testing and Generator-driven Property Checks.

hkeeler commented 9 years ago

Review complete. Overall looks good, though I think we should fix the Travis log spew issue before merging.

hkeeler commented 9 years ago

Travis is certainly much happier now. However, there are still a considerable number or ERRORs being logged related to SearchUtilsSpec.

There's about 50 entries that look like:

[2015-08-26 18:20:22,642][ERROR][pool-7-thread-9-ScalaTest-running-SearchUtilsSpec] For input string: "C"
[2015-08-26 18:20:22,643][ERROR][pool-7-thread-9-ScalaTest-running-SearchUtilsSpec] For input string: "B"

...and nearly 100 that look like:

[2015-08-26 18:20:22,738][ERROR][pool-7-thread-9-ScalaTest-running-SearchUtilsSpec] For input string: ""

I don't quite understand what these mean. It seems like an error logged from the internals of ScalaTest or ScalaCheck. The tests themselves all pass, and this error does not seem related to our own error logging when unparsable strings are passed in.

@jmarin, thoughts?

hkeeler commented 9 years ago

Nevermind. I must have been looking at a previous build or something. I don't see the above-mentioned errors in the latest Travis build. Merging...